Skip to content

Add duration parameter to network ping workload#581

Merged
imadityaa merged 5 commits into
microsoft:mainfrom
rudraptpsingh:user/rudrasingh/AddDurationParamterToNetworkPingWorkload
Oct 17, 2025
Merged

Add duration parameter to network ping workload#581
imadityaa merged 5 commits into
microsoft:mainfrom
rudraptpsingh:user/rudrasingh/AddDurationParamterToNetworkPingWorkload

Conversation

@rudraptpsingh
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@imadityaa imadityaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a Unit Test for the new parameter added

brdeyo
brdeyo previously requested changes Oct 14, 2025
Comment thread src/VirtualClient/VirtualClient.Actions/Network/NetworkPingExecutor.cs Outdated
Comment thread src/VirtualClient/VirtualClient.Actions/Network/NetworkPingExecutor.cs Outdated
Comment thread src/VirtualClient/VirtualClient.Actions/Network/NetworkPingExecutor.cs Outdated
@imadityaa imadityaa dismissed brdeyo’s stale review October 17, 2025 05:46

The comments have been acknowledged and resolved.

@imadityaa imadityaa merged commit 5346cff into microsoft:main Oct 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants